=== Applying patches on top of PostgreSQL commit ID f11674f8dfe811390dfeaf6f3c3a554dbeb790e1 === /etc/rc.d/jail: WARNING: Per-jail configuration via jail_* variables is obsolete. Please consider migrating to /etc/jail.conf. Thu Feb 20 06:01:24 UTC 2025 On branch cf/5492 nothing to commit, working tree clean === applying patch ./v7-0001-Remove-wal_-sync-write-_time-from-pg_stat_wal.patch Applied patch to 'doc/src/sgml/config.sgml' cleanly. Applied patch to 'doc/src/sgml/monitoring.sgml' with conflicts. Applied patch to 'doc/src/sgml/wal.sgml' with conflicts. Applied patch to 'src/backend/access/transam/xlog.c' cleanly. Applied patch to 'src/backend/catalog/system_views.sql' cleanly. Applied patch to 'src/backend/utils/activity/pgstat_wal.c' cleanly. Applied patch to 'src/backend/utils/adt/pgstatfuncs.c' cleanly. Applied patch to 'src/include/catalog/pg_proc.dat' cleanly. Applied patch to 'src/include/pgstat.h' cleanly. Applied patch to 'src/test/regress/expected/rules.out' cleanly. Applied patch to 'src/tools/pgindent/typedefs.list' cleanly. U doc/src/sgml/monitoring.sgml U doc/src/sgml/wal.sgml diff --cc doc/src/sgml/monitoring.sgml index 71c4f96d05,e645591ce5..0000000000 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@@ -2931,13 -2931,44 +2931,54 @@@ description | Waiting for a newly initi ++<<<<<<< ours + For the object wal, + fsyncs and fsync_time track the + fsync activity of WAL files done in issue_xlog_fsync. + writes and write_time + track the write activity of WAL files done in + XLogWrite. + See for more information. ++======= + For the wal object: + + + + writes is the number of times WAL buffers were + written out to disk via XLogWrite request (See + for more information about the internal WAL function XLogWrite). + + + + + fsyncs is the number of times WAL files were + synced to disk via issue_xlog_fsync request (if + is on and is either + fdatasync, fsync or fsync_writethrough, + otherwise zero) (See for more information about + the internal WAL function issue_xlog_fsync). + + + + + write_time is the total amount of time spent writing + WAL buffers to disk via XLogWrite request (if + is enabled, otherwise zero). This includes the sync time when wal_sync_method + is either open_datasync or open_sync. + + + + + sync_time is the total amount of time spent syncing + WAL files to disk via issue_xlog_fsync request (if + track_wal_io_timing is enabled, fsync is + on, and wal_sync_method is either + fdatasync, fsync or fsync_writethrough, + otherwise zero). + + + ++>>>>>>> theirs diff --cc doc/src/sgml/wal.sgml index 52b5b8f793,bb4892413f..0000000000 --- a/doc/src/sgml/wal.sgml +++ b/doc/src/sgml/wal.sgml @@@ -810,12 -810,11 +810,17 @@@ There are two internal functions to write WAL data to disk: XLogWrite and issue_xlog_fsync. - When is enabled, the total + When is enabled, the total amounts of time XLogWrite writes and issue_xlog_fsync syncs WAL data to disk are counted as ++<<<<<<< ours + write_time and fsync_time in + for the object + wal, respectively. ++======= + write_time and sync_time in + for the wal object, respectively. ++>>>>>>> theirs XLogWrite is normally called by XLogInsertRecord (when there is no space for the new record in WAL buffers), XLogFlush and the WAL writer, @@@ -830,12 -829,12 +835,18 @@@ fsync, or fsync_writethrough, the write operation moves WAL buffers to kernel cache and issue_xlog_fsync syncs them to disk. Regardless - of the setting of track_wal_io_timing, the number + of the setting of track_io_timing, the number of times XLogWrite writes and issue_xlog_fsync syncs WAL data to disk are also ++<<<<<<< ours + counted as writes and fsyncs + in pg_stat_io for the object + wal, respectively. ++======= + counted as write and sync + in pg_stat_io for the wal object + respectively. ++>>>>>>> theirs